Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Adding a few of datasets for benchmarking #5573

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[REVIEW] Adding a few of datasets for benchmarking #5573

merged 2 commits into from
Sep 19, 2023

Conversation

vinaydes
Copy link
Contributor

@vinaydes vinaydes commented Sep 5, 2023

This PR:

  • Adds following datasets - Airline for classification and regression, Bosch, Cover type, Epsilon, Fraud and Year
  • Removes default parameters for RF from algorithms.py since they are already set in the RF itself.
  • Changes the meaning of n_samples argument for gen_data
  • Adds logic for caching load of the datasets for faster benchmarking
  • Supports n_sample = 0 and n_features = 0, which causes loading of full dataset.

@vinaydes vinaydes requested a review from a team as a code owner September 5, 2023 12:09
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 5, 2023
vinaydes
vinaydes commented Sep 5, 2023
View reviewed changes
python/cuml/benchmark/runners.py
@@ -291,8 +299,6 @@ def _run_one_size(
for rep in cpu_timer.benchmark_runs():
cpu_model = algo_pair.run_cpu(
data,
**param_overrides,
**cpu_param_overrides,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing param_overrides and cpu_param_overrides causes and error if those parameters are actually present. This is because they already copied to the setup_override.

@vinaydes
Copy link
Contributor Author

vinaydes commented Sep 5, 2023

The build failures seems to be unrelated to this PR?

@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 19, 2023
@dantegd
Copy link
Member

dantegd commented Sep 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3e7f82b into rapidsai:branch-23.10 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinaydes @dantegd